On timeline loaded #3530

yotamberk · 2017-10-05T11:30:06Z

wimrijnders · 2017-10-07T08:07:05Z

docs/timeline/index.html

@@ -944,6 +944,14 @@ <h2 id="Configuration_Options">Configuration Options</h2>
    </tr>

    <tr>
+      <td>onInitialDrawComplete</td>


Small niggle on my part: The options are arranged alphabetically, this new entry and onUpdate are not.

wimrijnders · 2017-10-07T08:11:33Z

examples/timeline/interaction/eventListeners.html

@@ -34,7 +34,8 @@

    var container = document.getElementById('visualization');
    var options = {
-      editable: true
+      editable: true,
+      onInitialDrawComplete: function() { return logEvent('Timeline initial draw completed', {}) },


return not necessary. logEvent returns nothing.

wimrijnders · 2017-10-07T08:14:09Z

lib/timeline/Core.js

@@ -1003,7 +1003,6 @@ Core.prototype._redraw = function() {
  } else {
    this.redrawCount = 0;
  }
-  this.initialDrawDone = true;


Doesn't this need to be set? It's the only place in the module where it goes to true.

OK, got it. It's set in Timeline._activateOnInitialDrawDone(). I find it a bit confusing that this is in a derived class.

Timeline._activateOnInitialDrawDone() was incorrect. I removed it.

wimrijnders · 2017-10-07T08:18:54Z

lib/timeline/Timeline.js

+  if (!this.initialDrawDone) {
+    this.initialDrawDone = true;
+    setTimeout(() => {
+      if (this.options.onInitialDrawComplete) {


Why bother with setTimeOut if onInitialDrawComplete is not present? Better to move this condition out of setTimeOut.

wimrijnders · 2017-10-07T08:24:48Z

lib/timeline/Timeline.js

-      }
-      else {
-        me.fit({animation: false});
+        me.setWindow(start, end, {animation: false}, this._activateOnInitialDrawDone.bind(this));


Strictly speaking, calling it here is a lie; _redraw() is done at the end of this method. initialDrawDone should be set to true after that call, same applies to the callback.

wimrijnders · 2017-10-07T08:31:29Z

lib/timeline/Timeline.js

@@ -411,21 +421,22 @@ Timeline.prototype.focus = function(id, options) {
 *                                    provided to specify duration and easing function.
 *                                    Default duration is 500 ms, and default easing
 *                                    function is 'easeInOutQuad'.
+ * @param {Function} callback


@param {function} [callback]

casing, callback optional

wimrijnders

OK looks good. Just that one unrelated question about the double code tags.

wimrijnders · 2017-10-07T14:02:44Z

docs/timeline/index.html

    <tr>
      <td>onMoving</td>
      <td>function</td>
      <td>none</td>
      <td>Callback function triggered repeatedly when an item is being moved. See section <a href="#Editing_Items">Editing Items</a> for more information. Only applicable when both options <code>selectable</code> and <code>editable.updateTime</code> or <code>editable.updateGroup</code> are set <code><code>true</code></code>.
      </td>
    </tr>
-
+    
    <tr>
      <td>onRemove</td>
      <td>function</td>
      <td>none</td>
      <td>Callback function triggered when an item is about to be removed: when the user tapped the delete button on the top right of a selected item. See section <a href="#Editing_Items">Editing Items</a> for more information. Only applicable when both options <code>selectable</code> and <code>editable.remove</code> are set <code><code>true</code></code>.


Er, why the double <code> tags? It happens more often in the docs.

wimrijnders · 2017-10-07T14:03:30Z

lib/timeline/Core.js

@@ -111,6 +111,11 @@ Core.prototype._create = function (container) {
      this._redraw();
    }
  }.bind(this));
+  this.on('rangechanged', function () {


Yes, this is a better place.

wimrijnders · 2017-10-07T14:06:42Z

lib/timeline/Timeline.js

+      }
+    }
+
+    if (!me.initialDrawDone && me.initialRangeChangeDone) {


Ah yes right. If I was just a bit clearer in my head I should have remarked on that. Make sense, not directly connected to the while-loop.

yotamberk · 2017-10-07T14:34:20Z

@wimrijnders seems like that <code><code> was in many places... thanks for noticing!

wimrijnders

OK! We're done here. Let's get this thing merged.

* initial trial * Add onInitialDrawComplete * Add docs * Add to eventListeners examples * Keeping things DRY * Remove callback insertion * Remove call * Fix initial real first draw complete and fix comments from review * remove all <code><code>

yotamberk added 5 commits September 30, 2017 18:01

initial trial

c1c05d5

Add onInitialDrawComplete

576ea87

Add docs

f6b9779

Add to eventListeners examples

c759961

Keeping things DRY

011a929

yotamberk changed the base branch from master to develop October 5, 2017 11:30

yotamberk added 2 commits October 5, 2017 14:31

Remove callback insertion

907ccbd

Remove call

346dac2

yotamberk added Feature-Request Timeline labels Oct 5, 2017

yotamberk requested a review from wimrijnders October 7, 2017 07:49

wimrijnders suggested changes Oct 7, 2017

View reviewed changes

Fix initial real first draw complete and fix comments from review

96738e0

wimrijnders suggested changes Oct 7, 2017

View reviewed changes

yotamberk added 2 commits October 7, 2017 17:29

Merge branch 'develop' into on-timeline-loaded

5a985d4

remove all <code><code>

78227c5

wimrijnders approved these changes Oct 7, 2017

View reviewed changes

yotamberk merged commit 6afc095 into almende:develop Oct 7, 2017

MosheAtOwal mentioned this pull request Aug 16, 2018

Timeline Doesn't Appear Without User Interaction #4082

Open

MosheAtOwal mentioned this pull request Sep 26, 2018

Timeline Doesn't Appear Without User Interaction yotamberk/timeline-plus#52

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On timeline loaded #3530

On timeline loaded #3530

yotamberk commented Oct 5, 2017

wimrijnders Oct 7, 2017

wimrijnders Oct 7, 2017

wimrijnders Oct 7, 2017

wimrijnders Oct 7, 2017

yotamberk Oct 7, 2017

wimrijnders Oct 7, 2017

wimrijnders Oct 7, 2017

wimrijnders Oct 7, 2017

wimrijnders left a comment

wimrijnders Oct 7, 2017

wimrijnders Oct 7, 2017

wimrijnders Oct 7, 2017

yotamberk commented Oct 7, 2017

wimrijnders left a comment

On timeline loaded #3530

On timeline loaded #3530

Conversation

yotamberk commented Oct 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wimrijnders left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yotamberk commented Oct 7, 2017

wimrijnders left a comment

Choose a reason for hiding this comment